gtristan commented on code in PR #1903:
URL: https://github.com/apache/buildstream/pull/1903#discussion_r1539379591
##########
src/buildstream/sourcemirror.py:
##########
@@ -93,6 +93,13 @@ class SourceMirror(Plugin):
# The SourceMirror plugin type is only supported since BuildStream 2.2
BST_MIN_VERSION = "2.2"
+ COMMON_CONFIG_KEYS = ["name", "kind"]
Review Comment:
I've always considered this to be an imperfection which we did exclusively
for `Source` definitions, and feel regret for this inconsistency, it seems
delicate to try to share the namespace between the core object and subclasses.
I would be more comfortable with:
```yaml
name: sonya
kind: pony
config:
fur: pink
tail: yellow
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
