abderrahim commented on code in PR #1903:
URL: https://github.com/apache/buildstream/pull/1903#discussion_r1539392094
##########
src/buildstream/_pluginfactory/sourcemirrorfactory.py:
##########
@@ -62,9 +62,9 @@ def create(self, context: "Context", project: "Project",
node: MappingNode) -> S
#
kind = node.get_str("kind", None)
if kind is None:
- plugin_type = SourceMirror
- else:
- plugin_type, _ = self.lookup(context.messenger, kind, node)
+ kind = "legacy"
Review Comment:
Yeah, I was considering that. I thought we might want to have `default`
mirror plugin with a better usability (adding support for extra data, maybe
dropping the multiple urls per alias) while keeping compatibility with the old
mirrors.
If you think we can make improvements without breaking compatibility, I can
change it to `default`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
