abderrahim commented on code in PR #1903:
URL: https://github.com/apache/buildstream/pull/1903#discussion_r1540668859
##########
src/buildstream/_project.py:
##########
@@ -382,12 +402,18 @@ def alias_exists(self, alias, *, first_pass=False):
# get_alias_uris()
#
# Args:
- # alias (str): The alias.
- # first_pass (bool): Whether to use first pass configuration (for
junctions)
- # tracking (bool): Whether we want the aliases for tracking (otherwise
assume fetching)
+ # alias: The alias.
+ # first_pass: Whether to use first pass configuration (for junctions)
+ # tracking: Whether we want the aliases for tracking (otherwise assume
fetching)
+ #
+ # Returns:
+ # A list of (SourceMirror, string) tuples with each alias substitution
found along
+ # with the SourceMirror object which produced it.
Review Comment:
> These lists/values of imprecise type are passed through various functions
that expect a string (according to the parameter type)
Forgot to change the type annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
