gtristan commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2550020449
##########
src/buildstream/source.py:
##########
@@ -572,6 +579,31 @@ def __init__(
The url of the source input
"""
+ self.attribution_text: Optional[str] = attribution_text
+ """
+ Required acknowledgements for the package
Review Comment:
Out of all of these added attributes... this is the only one which doesn't
clearly mean anything to me.
An example of this could be like *"This package is based on <other person>s
code from <project>"* ?
That's what I think *"attribution"* could mean... on the other hand:
*required acknowledgements* probably means something like *"We are aware that
usage of this package will harm baby seals when deployed in proximity to a
hockey game"*
Maybe something a bit more specific for the docs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
