abderrahim commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2550209924
##########
src/buildstream/source.py:
##########
@@ -582,6 +614,16 @@ def __init__(
The project issue tracking URL
"""
+ self.name: Optional[str] = name
+ """
+ Name of the project
+ """
+
+ self.supplier: Optional[str] = supplier
+ """
+ The name of the project suppliers/owners
Review Comment:
Could we also add `originator`? If we're trying to follow SPDX, it would be
nice to have this differentiation.
See
https://spdx.github.io/spdx-spec/v2.3/package-information/#75-package-supplier-field
vs
https://spdx.github.io/spdx-spec/v2.3/package-information/#76-package-originator-field
##########
src/buildstream/source.py:
##########
Review Comment:
Another thing that I feel would be useful to have is the external reference:
https://spdx.github.io/spdx-spec/v2.3/package-information/#721-external-reference-field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
