gtristan commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2550424798


##########
src/buildstream/source.py:
##########
@@ -572,6 +579,31 @@ def __init__(
         The url of the source input
         """
 
+        self.attribution_text: Optional[str] = attribution_text
+        """
+        Required acknowledgements for the package

Review Comment:
   Note that an argument can be made for supporting a general field named 
something like *"legal_notes"*, intentionally not being conformant to SPDX, 
which is "take it or leave it", if the underlying motivation for including this 
is that users need a place to write some *"extra legal stuff"*.
   
   The downside of this would be that we couldn't justifiably be able to map it 
to an SPDX value if we want to use this stuff to generate SBoMs in SPDX format.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to