gtristan commented on code in PR #2095:
URL: https://github.com/apache/buildstream/pull/2095#discussion_r2550647973
##########
src/buildstream/source.py:
##########
@@ -582,6 +614,16 @@ def __init__(
The project issue tracking URL
"""
+ self.name: Optional[str] = name
+ """
+ Name of the project
+ """
+
+ self.supplier: Optional[str] = supplier
+ """
+ The name of the project suppliers/owners
Review Comment:
Good point: I would argue that we drop *supplier* entirely.
The originator text again makes references to *packages* (in context of the
*supplier*), which we don't usually consume:
> For example, the SPDX document identifies the package as
[glibc](https://www.gnu.org/software/libc/) and the Package Supplier as [Red
Hat](https://www.redhat.com/), but the [Free Software
Foundation](http://www.fsf.org/) is the Package Originator.
The above is biased towards redhat of course... glibc's *supplier* is only
RedHat if you received the package as an RPM, but it could have been supplied
in many other ways.
With BuildStream, we normally only care about the *originator*, and the
BuildStream user is generally the *supplier* themselves, if I've understood the
text correctly.
In this light, I'd agrue that we drop *supplier* from the initially proposed
fields, and **only** care about the originator (yes we have some oddball
plugins which support debian packages as sources... but they are unused
outliers).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
