danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve
design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r279149934
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java
##########
@@ -347,7 +346,7 @@ public JoinReduceExpressionsRule(Class<? extends Join>
joinClass,
matchNullability)) {
return;
}
- if (join instanceof EquiJoin) {
+ if (RelOptUtil.forceEquiJoin(join)) {
Review comment:
Cause for current implementation there are some Enumerable joins that do not
support non-equi join condition, this is just a sanity check, see @dev discuss:
https://lists.apache.org/list.html?d...@calcite.apache.org:lte=1M:support%20non-equi%20join
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
