strongduanmu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1818226356
##########
core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java:
##########
@@ -303,7 +303,7 @@ public static SqlOperatorTable operatorTable(String...
classNames) {
}
/** Converts a function to a {@link org.apache.calcite.sql.SqlOperator}. */
- private static SqlOperator toOp(SqlIdentifier name,
+ private SqlOperator toOp(SqlIdentifier name,
Review Comment:
Since we need to call the non-static `config` field inside the toOp method
to determine `config.conformance().allowNiladicParentheses()`, the toOp method
cannot be a static method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
