strongduanmu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1818240858
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlUserDefinedFunction.java:
##########
@@ -61,9 +64,9 @@ public SqlUserDefinedFunction(SqlIdentifier opName, SqlKind
kind,
SqlReturnTypeInference returnTypeInference,
SqlOperandTypeInference operandTypeInference,
@Nullable SqlOperandMetadata operandMetadata,
- Function function) {
+ Function function, SqlSyntax syntax) {
Review Comment:
Hi @mihaibudiu thank you for your suggestion. I found this public
constructor, which is only called in the `CalciteCatalogReader#toOp` method.
When we add SqlSyntax to the toOp method, the original constructor that does
not contain SqlSyntax will not be called.
In this case, does it make sense to keep a constructor that is not called?
In addition, I don't know whether this constructor will be called by the user.
If the user can call it, then we should indeed keep the original constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
