strongduanmu commented on code in PR #4019:
URL: https://github.com/apache/calcite/pull/4019#discussion_r1818244036
##########
testkit/src/main/java/org/apache/calcite/util/Smalls.java:
##########
@@ -683,6 +683,13 @@ public static int eval(int x) throws
IllegalArgumentException, IOException {
}
}
+ /** User-defined function with niladic parentheses. */
+ public static class MyNiladicParenthesesFunction {
+ public String eval() {
Review Comment:
Do you have any suggestions for better naming for constants used like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]