Croway commented on PR #27173: URL: https://github.com/apache/camel/pull/27173#issuecomment-5928640804
yeah, kafka will not follow the standard for batching since it has more features, that comes from the actual Kafka-client, so I'd change only the sjms ones, and in future align the other components: | Current | Rename to | Type / default | Note | |---|---|---|---| | `batching` | `batching` | boolean, `false` | unchanged, already matches camel-kafka | | `batchingSize` | `batchSize` | int, `100` | | | `batchingTimeout` | **remove** | | the idle-reset semantics go away | | `batchingInterval` | `batchTimeout` | `java.time.Duration`, `1000` | keep *this* implementation, under the new name | | `batchingAggregationStrategy` | **remove** | | ship List<Exchange> only, as camel-kafka does; a pluggable strategy can follow in its own issue, named aggregationStrategy | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
