davsclaus commented on PR #27173: URL: https://github.com/apache/camel/pull/27173#issuecomment-5946618434
Thanks @mionker, and no worries about the imports. Yes, please go ahead and push the changes to this PR yourself: the option rename per Croway's table (`batch`/`batchSize`/`batchTimeout` as a `Duration`, drop `batchingTimeout` and the aggregation strategy for now), plus the points in my earlier review. Error handling (3), the AUTO_ACKNOWLEDGE warning (4) and the connection-loss discard path (5) matter most. After the rename, please re-run the build for camel-sjms, camel-sjms2, catalog and endpoint-dsl so the generated files are refreshed, and add a `Co-authored-by` trailer for the AI tools. _Claude Code on behalf of davsclaus_ _This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
