Croway commented on PR #27173: URL: https://github.com/apache/camel/pull/27173#issuecomment-5927836586
Hi @mionker thanks for the PR, I have two requests, the first one is about naming convention since I'm planning to harmonize the batching consumers across Camel under CAMEL-20368, so that `camel-sjms`, `camel-spring-rabbitmq`, `camel-pulsar` and `camel-rocketmq` expose the same vocabulary and the same exchange contract as `camel-kafka`, ideally with shared plumbing rather than four hand-rolled receive loops. This PR is the second component to get batching, so whatever names land here will effectively become the template, and renaming later costs an upgrade-guide entry per component. Right now there are three different vocabularies for the same four concepts: | Concept | This PR | Removed sjms-batch | camel-kafka | |---|---|---|---| | Max messages | `batchingSize` | `completionSize` | `maxPollRecords` | | Window from first message | `batchingInterval` | `completionInterval` | `batchingIntervalMs` | | Idle window | `batchingTimeout` | `completionTimeout` | `pollTimeoutMs` | | Strategy | `batchingAggregationStrategy` | `aggregationStrategy` | n/a | @davsclaus already asked you to move to `batching` / `batchSize` / a single `batchTimeout` per the design recorded on CAMEL-16039, so this is really the same request with an extra reason behind it. Concretely, would you be willing to use: - `batching` — already matches camel-kafka, no change needed - `batchSize` — instead of `batchingSize` - `batchTimeout` — instead of `batchingTimeout` - `aggregationStrategy` — instead of `batchingAggregationStrategy`, if the option stays at all; it matches both the Aggregator EIP and the old sjms-batch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
