gnodet-bot commented on code in PR #29706:
URL: https://github.com/apache/camel/pull/29706#discussion_r4549132947
##########
components/camel-aws/camel-aws2-transcribe/src/main/java/org/apache/camel/component/aws2/transcribe/Transcribe2Configuration.java:
##########
@@ -263,14 +265,14 @@ public void setProfileCredentialsName(String
profileCredentialsName) {
}
/**
- * To define a proxy protocol when instantiating the Transcribe client
+ * The protocol to use when instantiating the Transcribe client
*/
public Protocol getProtocol() {
Review Comment:
⚠️ **Missing deprecation markers on getter.**
The field has `@Deprecated` and `@Metadata(deprecationNote=...)`, but the
getter is missing both `@Deprecated` and a `@deprecated` Javadoc tag. Per Camel
convention:
```suggestion
/**
* The protocol to use when instantiating the Transcribe client
*
* @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
@Deprecated
public Protocol getProtocol() {
```
##########
components/camel-aws/camel-aws2-transcribe/src/main/java/org/apache/camel/component/aws2/transcribe/Transcribe2Configuration.java:
##########
@@ -263,14 +265,14 @@ public void setProfileCredentialsName(String
profileCredentialsName) {
}
/**
- * To define a proxy protocol when instantiating the Transcribe client
+ * The protocol to use when instantiating the Transcribe client
*/
public Protocol getProtocol() {
return protocol;
}
/**
- * To define a proxy protocol when instantiating the Transcribe client
+ * The protocol to use when instantiating the Transcribe client
*/
public void setProtocol(Protocol protocol) {
Review Comment:
⚠️ **Missing deprecation markers on setter.**
Same issue as the getter: `@Deprecated` and `@deprecated` Javadoc tag are
missing.
```suggestion
/**
* The protocol to use when instantiating the Transcribe client
*
* @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
@Deprecated
public void setProtocol(Protocol protocol) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
