Dhairya-007 commented on PR #29706:
URL: https://github.com/apache/camel/pull/29706#issuecomment-6827627210
**Rebased on main** — the branch had gone `CONFLICTING` on
`camel-4x-upgrade-guide-4_24.adoc`, the same spot #29681 hit: main added the
camel-docling OCR-headers entry there. Both entries kept, main's first. No code
changed in the rebase.
While re-checking the branch I verified the two things I had asserted
without proof in my earlier reply, since both are the kind of claim that is
cheap to make and expensive to get wrong:
**The generated description is exactly what a regen would produce.** I had
said the `. Deprecation note:` joining was right; the generator is
`EndpointSchemaGeneratorMojo#L764-769`:
```java
if (!Strings.isNullOrEmpty(option.getDeprecationNote())) {
if (!sb.isEmpty() && sb.charAt(sb.length() - 1) != '.') {
sb.append('.');
}
sb.append(" Deprecation note: ").append(option.getDeprecationNote());
}
```
So the period is inserted by the generator, not by the Javadoc — which is
why the Javadoc has no trailing period and the JSON does. Both JSON copies are
byte-identical to each other (`diff` clean).
**`getProtocol()` really has no reader.**
`Transcribe2ComponentConfigurer#L147` is the only call site in the module, i.e.
the generated configurer reflecting the option back out. Nothing on the
client-building path touches it.
One point worth stating plainly, since it is a description change and not
just a deprecation: the old text was **"To define a proxy protocol when
instantiating the Transcribe client"**. That is `proxyProtocol`'s description —
and `proxyProtocol` exists separately in the same class, is a `Protocol`, and
*is* read. So the old text documented `protocol` as the proxy setting it is
not, which would send anyone who reads the catalog to the wrong option. That is
why the new text is "The protocol to use when instantiating the Transcribe
client" rather than a straight copy of the original, and the upgrade-guide
entry says so. Happy to split that into its own commit if you would rather keep
the deprecation diff minimal.
The deprecation markers you asked for are on the field and on both
accessors, and the duplicate Javadoc blocks are collapsed to the single block
carrying the `@deprecated` tag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
