Dhairya-007 commented on PR #29706:
URL: https://github.com/apache/camel/pull/29706#issuecomment-6825161311
Fixed — and thanks for spotting it; the irony of leaving orphaned Javadoc
behind is not lost on me, given #29641.
Both pairs on `getProtocol()` and `setProtocol()` are collapsed into the
single block that carries the `@deprecated` tag:
```java
/**
* The protocol to use when instantiating the Transcribe client
*
* @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
@Deprecated
public Protocol getProtocol() {
```
I checked the file for any other adjacent `*/` … `/**` pair and there are
none left.
**The generated metadata is unchanged by this**, which is worth stating
explicitly since I cannot run the regen here: the schema generator reads the
*last* Javadoc block before the member, and that block's first line is the same
text as the orphan's, so the description in both JSON copies and in the two DSL
factories stays byte-identical. I re-read them after the edit to confirm.
**On `mvn formatter:format impsort:sort`** — I cannot run maven in this
environment, so I checked by hand instead: no line in the touched region
exceeds 120 columns, the blank `*` separator before the tag is there, and no
imports changed. If the formatter still has an opinion, the regen job's patch
will show it and I will apply it.
**On the rebase heads-up** — agreed, #29706 and #29709 both append to
`camel-4x-upgrade-guide-4_24.adoc`. Whichever lands second I will rebase;
#29709 already needs one, so I am doing that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
