gnodet-bot commented on code in PR #29706:
URL: https://github.com/apache/camel/pull/29706#discussion_r4549472309
##########
components/camel-aws/camel-aws2-transcribe/src/main/java/org/apache/camel/component/aws2/transcribe/Transcribe2Configuration.java:
##########
@@ -263,15 +265,27 @@ public void setProfileCredentialsName(String
profileCredentialsName) {
}
/**
- * To define a proxy protocol when instantiating the Transcribe client
+ * The protocol to use when instantiating the Transcribe client
+ */
+ /**
+ * The protocol to use when instantiating the Transcribe client
+ *
+ * @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
+ @Deprecated
Review Comment:
⚠️ **Duplicate Javadoc block.** There are two consecutive `/** ... */`
comments before `getProtocol()`. Java only associates the last Javadoc block
immediately preceding a declaration — the first one is a stray orphan that will
be silently ignored by `javadoc` and IDEs. Remove it and keep only the second
block (the one with `@deprecated`).
```suggestion
/**
* The protocol to use when instantiating the Transcribe client.
*
* @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
@Deprecated
```
##########
components/camel-aws/camel-aws2-transcribe/src/main/java/org/apache/camel/component/aws2/transcribe/Transcribe2Configuration.java:
##########
@@ -263,15 +265,27 @@ public void setProfileCredentialsName(String
profileCredentialsName) {
}
/**
- * To define a proxy protocol when instantiating the Transcribe client
+ * The protocol to use when instantiating the Transcribe client
+ */
+ /**
+ * The protocol to use when instantiating the Transcribe client
+ *
+ * @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
+ @Deprecated
public Protocol getProtocol() {
return protocol;
}
/**
- * To define a proxy protocol when instantiating the Transcribe client
+ * The protocol to use when instantiating the Transcribe client
+ */
+ /**
+ * The protocol to use when instantiating the Transcribe client
+ *
+ * @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
+ @Deprecated
Review Comment:
⚠️ **Duplicate Javadoc block.** Same issue as `getProtocol()`: two
consecutive `/** ... */` before `setProtocol()`. Remove the stray first block.
```suggestion
/**
* The protocol to use when instantiating the Transcribe client.
*
* @deprecated Not used: nothing reads this option when the Transcribe
client is built
*/
@Deprecated
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
