[ 
https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129976#comment-17129976
 ] 

Alex Deparvu commented on CASSANDRA-14888:
------------------------------------------

thanks [~maedhroz] for the review. I have rebased & updated the patch. [0]
the only changes still missing are the tests for ViewWriteMetrics, which I will 
add soon.
please take a look and let me know if it looks good so far.


[0] 
https://github.com/apache/cassandra/compare/trunk...stillalex:CASSANDRA-14888

> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-14888
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Observability/Metrics
>            Reporter: Ariel Weisberg
>            Assignee: Alex Deparvu
>            Priority: Urgent
>              Labels: patch-available
>             Fix For: 4.0-beta
>
>         Attachments: CASSANDRA-14888.patch
>
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests, 
> ShortReadProtectionRequests, AntiCompactionTime, BytesValidated, 
> PartitionsValidated, RepairPrepareTime, RepairSyncTime, 
> RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime, 
> WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the 
> entire thing is kind of obscure. Fix it and also add a dtest that detects if 
> any mbeans are left behind after dropping a table and keyspace.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to