[
https://issues.apache.org/jira/browse/CASSANDRA-14888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132664#comment-17132664
]
Caleb Rackliffe commented on CASSANDRA-14888:
---------------------------------------------
[~stillalex] There is one real problem I think we need to address. In
{{KeyspaceMetricNameFactory#release()}}, we call {{createMetricName()}}, which
adds names to {{allMetrics}}, _while we're iterating over_ {{allMetrics}}.
You'll either need to store {{MetricName}} instances in {{allMetrics}}, so you
can avoid the call to {{createMetricName()}}, or go back to something more like
the approach in {{TableMetrics}}, keeping the metric lifecycle separate from
the factory itself. (I lean toward the {{TableMetrics}} approach, given the
helper methods might make it a little easier to add things going forward, and
it doesn't fragment the responsibilities of the factory, but I could be wrong
there.)
By the way, when we get to a good place (maybe after the MV test is ready) I'll
cherry-pick your commit into my fork and run it through CircleCI. (The free
tier hardware is a bit lacking...)
> Several mbeans are not unregistered when dropping a keyspace and table
> ----------------------------------------------------------------------
>
> Key: CASSANDRA-14888
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14888
> Project: Cassandra
> Issue Type: Bug
> Components: Observability/Metrics
> Reporter: Ariel Weisberg
> Assignee: Alex Deparvu
> Priority: Urgent
> Labels: patch-available
> Fix For: 4.0-beta
>
> Attachments: CASSANDRA-14888.patch
>
>
> CasCommit, CasPrepare, CasPropose, ReadRepairRequests,
> ShortReadProtectionRequests, AntiCompactionTime, BytesValidated,
> PartitionsValidated, RepairPrepareTime, RepairSyncTime,
> RepairedDataInconsistencies, ViewLockAcquireTime, ViewReadTime,
> WriteFailedIdealCL
> Basically for 3 years people haven't known what they are doing because the
> entire thing is kind of obscure. Fix it and also add a dtest that detects if
> any mbeans are left behind after dropping a table and keyspace.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
