[
https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17479687#comment-17479687
]
Andres de la Peña commented on CASSANDRA-17212:
-----------------------------------------------
I don't find that structure so appealing for things like the thresholds for
{{{}replica_filtering_protection{}}}. I understand that in that spirit it will
look like:
{code:java}
limits:
warn:
replica_filtering_protection_cached_rows: 2000
(other warn thresholds)
fail:
replica_filtering_protection_cached_rows: 32000
(other fail thresholds)
{code}
Where would we place the detailed comments about what RFP is, and what its
cache does, etc.? Should we repeat the comments in both the warn and the fail
thresholds? I don't think we can find a self-documenting name for something
like that.
That said, the property {{default_keyspace_rf}} doesn't match what is covered
by thresholds, and probably we are not interested on a warn threshold for
replication factor. So maybe we should just not use guardrails for this one,
independently of how we structure the config file.
As for restructuring the config file in general, that seems to deserve a
separate ticket and probably a discussion on the mail list, especially if
that's going to block work on other features like new guardrails like
CASSANDRA-17188, wdyt?
> Migrate threshold for minimum keyspace replication factor to guardrails
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-17212
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17212
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Priority: Normal
>
> The config property
> [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml]
> that was added by CASSANDRA-14557 can be migrated to guardrails, for example:
> {code}
> guardrails:
> ...
> replication_factor:
> warn_threshold: 2
> abort_threshold: 3
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
