[
https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480223#comment-17480223
]
Josh McKenzie commented on CASSANDRA-17212:
-------------------------------------------
Full disclosure, I'm with David on preferring the 2nd option. My intuition is
that having these thresholds for guardrails visible together (info, warn, fail)
will be less error prone to configure and subsequently modify than if those
values live separately from one another.
bq. For example, is this how you view the other properties?
I think this is a bit of a straw man. These are all examples of one-shot values
that are domain specific and aren't related outside of the fact that they limit
things, and in this case specifically, thread counts. If we had a "info, warn,
error" level for read threadpool concurrency then I'd advocate we co-locate
them as well, else it'd be far too easy to make a mistake when configuring it
and/or have values that weren't particularly sensible compared to one another.
Specifically re:
bq. do we group under info/warn/fail or do we group at the feature which also
offers info/warn/fail?
I don't think anybody is currently advocating for the statement: "concurrency
is a feature and we should group parameters under that".
> Migrate threshold for minimum keyspace replication factor to guardrails
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-17212
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17212
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Priority: Normal
>
> The config property
> [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml]
> that was added by CASSANDRA-14557 can be migrated to guardrails, for example:
> {code}
> guardrails:
> ...
> replication_factor:
> warn_threshold: 2
> abort_threshold: 3
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
