[ https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480026#comment-17480026 ]
Andres de la Peña commented on CASSANDRA-17212: ----------------------------------------------- I agree that we should move toward nesting, the part that I'm not convinced about is grouping warn/fail thresholds. That dev mail discussion thread about nesting was started during the guardrails prototype, that's why guardrails are already nested. We might change how properties are grouped and/or named in the future, but I also think that those changes can be easily retrofitted at a later stage, and that shouldn't stop us from adding new guardrails with the current structure. The guardrails framework systematizes how certain soft/hard limits are treated, so it should make it easier for us to move to a different yaml structure once we have agreed on it, compared to porting many ad-hoc limits. > Migrate threshold for minimum keyspace replication factor to guardrails > ----------------------------------------------------------------------- > > Key: CASSANDRA-17212 > URL: https://issues.apache.org/jira/browse/CASSANDRA-17212 > Project: Cassandra > Issue Type: New Feature > Components: Feature/Guardrails > Reporter: Andres de la Peña > Priority: Normal > > The config property > [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml] > that was added by CASSANDRA-14557 can be migrated to guardrails, for example: > {code} > guardrails: > ... > replication_factor: > warn_threshold: 2 > abort_threshold: 3 > {code} -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org