[
https://issues.apache.org/jira/browse/CASSANDRA-17212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17480321#comment-17480321
]
David Capwell commented on CASSANDRA-17212:
-------------------------------------------
bq. Discoverability remains poor
To me grouping based off feature is the only way for a config to actually be
"discoverable", pulling bits and pieces out to other places because they are
"limits" would always break this in my mind. If I want to see how to configure
compaction, I would look at the configs I know are for compaction, but having
them scattered under "limits" (limits.concurrency.compaction,
limits.throughput.compaction, etc.) will always make this much harder to find
what actually impacts compaction... so if we want to solve for discovery, then
the only solution I can see is
{code}
compaction:
# configs related to compaction goes here; including limits
query:
# configs related to queries goes here; including limits
repair:
# configs related to repairs goes here; including limits
{code}
aka, group by feature/domain. So in this model a top level "limits" shouldn't
exist, if we want to solve for discoverability.
bq. but also this is almost inherently inconsistent as we are already grouping
under a concept heading by using limits. What about other row_index things that
aren't limits?
This actually reads like an argument in favor of a feature/domain grouping. We
had tried to talk about things in "[DISCUSS] Nested YAML configs for new
features" and thought that we were inline with your thinking; but seems that
isn't true.
Can we move this conversation/decision to its own JIRA/CEP that we vote on; I
feel that an extension to an existing feature isn't the best place for such
discussion. If you want to take on this work, I will support you.
> Migrate threshold for minimum keyspace replication factor to guardrails
> -----------------------------------------------------------------------
>
> Key: CASSANDRA-17212
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17212
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Andres de la Peña
> Priority: Normal
>
> The config property
> [{{minimum_keyspace_rf}}|https://github.com/apache/cassandra/blob/5fdadb25f95099b8945d9d9ee11d3e380d3867f4/conf/cassandra.yaml]
> that was added by CASSANDRA-14557 can be migrated to guardrails, for example:
> {code}
> guardrails:
> ...
> replication_factor:
> warn_threshold: 2
> abort_threshold: 3
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
