[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616102#comment-17616102
]
David Capwell commented on CASSANDRA-17939:
-------------------------------------------
bq. An alternative would be doing the diff on the generate.sh script and assume
that that not-open source script will also be updated to add the soon-to-be
mandatory repeated tests. David Capwell wdyt?
If you have logic to detect what to run as a repeat, replicating in my script
wouldn't be hard...
bq. It would be great to have either that or those not-open source scripts,
although that seems out of the scope of this ticket.
I really should just post it... its not the "perfect" that I want which is why
I kept holding it off... Ideally I want to rewrite all our CircleCI and my
script is a tmp solution until we do that...
bq. I agree that the HIGHRES config is a waste of resources, that's why we
added the MIDRES config some time ago
The issue we face is 1) number of workers are randomly chosen and not based off
the work needed, 2) we really didn't put in a lot of effort to say we need
xlarge vs medium images. We are also not consistent due to the patching nature
of this work (filed a ticket to move away from patches but that had concerns
due to 4.1 being branched soon), so some times HIGHER uses mid resources and
some times MID uses xlarge...
bq. The fact that we have a good number of developers not using the generate.sh
but a parallel not-open source script seems to support the decision of running
the diffs on CircleCI instead of on that script
If you add a new job to the workflow my script will drop it... so if you are
changing what you plan to do based off my non-OSS script... don't bother =).
I personally feel the logical place for this work is generate.sh as that is the
only place that can "learn" what needs to happen and if we even need the new
job...
I have a few things on my plate so will be slow to review this work; don't
think you need to block on my review if others have more cycles.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
