[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617292#comment-17617292
]
Josh McKenzie commented on CASSANDRA-17939:
-------------------------------------------
generate.sh looks fine enough to me. Well documented, as clean as bash gets,
and works. There's _a lot_ of config yaml changes and I'm not sure how to
effectively review those changes, so for now I'll settle for the proxy of "I
ran it on multiple configurations and it all appears to be working".
Functional question for you: if you make a change to a long or stress test, the
current script auto-detects that and then sets up the config with the same
repeat run count:
{code:java}
REPEATED_TESTS_COUNT: 500
...
REPEATED_UTESTS_LONG_COUNT: REPEATED_TESTS_COUNT
{code}
My intuition is that we probably want a different default repeat count for LONG
and STRESS tests that's lower than the default count for other types of tests
given a) their much longer runtime, and b) a different profile / frequency of
flaking out. Not sure what that number should be; I'd probably start at an
order of magnitude down under the assumption that they take that much longer to
run, but that's a very non-scientific position for me to take.
WDYT [~adelapena]?
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
