[
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617297#comment-17617297
]
Andres de la Peña commented on CASSANDRA-17939:
-----------------------------------------------
{quote}There's _a lot_ of config yaml changes and I'm not sure how to
effectively review those changes, so for now I'll settle for the proxy of "I
ran it on multiple configurations and it all appears to be working".
{quote}
That should be enough :). The only relevant yaml file is
[{{config-2_1.yml}}|https://github.com/apache/cassandra/blob/388845dc3852154710a9dd8e98f35a120c405745/.circleci/config-2_1.yml],
the others are just files generated by {{generate.sh -a}}. I usually check
that running that command doesn't change the pre-built {{config.yml}} files
that are included in the patch. It also could make sense to diff the
low/mid/high files and verify that there aren't surprises when comparing them.
Other than that, it's just verifying that it works.
{quote}
My intuition is that we probably want a different default repeat count for LONG
and STRESS tests that's lower than the default count for other types.
{quote}
Yep, I was thinking the same. I'll change it to 50 or 100 and give it a run to
see how long it takes. Ideally all repeated jobs should complete in more or
less the same time, so I'll try to adjust to that.
> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
> Key: CASSANDRA-17939
> URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
> Project: Cassandra
> Issue Type: Task
> Components: CI
> Reporter: Andres de la Peña
> Priority: Normal
> Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically
> detects new or modified test classes and runs them repeatedly. That way we
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
