[ 
https://issues.apache.org/jira/browse/CASSANDRA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616585#comment-17616585
 ] 

Andres de la Peña commented on CASSANDRA-17939:
-----------------------------------------------

{quote}nit: wdyt about renaming the j8_build approval step on j8_pre-commit to 
something like "all_jdk_build"? Also, could serve to rename j8_pre-commit to 
"all_jdk_precommit". 
[https://app.circleci.com/pipelines/github/adelapena/cassandra/2218/workflows/1cc5669f-e894-488d-a47c-99e2c4d32acd]

That way we could document it as the "one-stop-shop" to hit the button and get 
all your test results.
{quote}
I don't think that's an all jdk build, nor that we should only use that 
workflow. That workflow tests building with j8 and running with both j8 and 
j11. The j11 workflow is for both building and running with j11. We should be 
running both workflows before committing.

 

> CircleCI: Automatically detect and repeat new or modified JUnit tests
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-17939
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17939
>             Project: Cassandra
>          Issue Type: Task
>          Components: CI
>            Reporter: Andres de la Peña
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> The purpose of this ticket is adding a new CircleCI job that automatically 
> detects new or modified test classes and runs them repeatedly. That way we 
> wouldn't need to manually specify those tests with {{.circleci/generate.sh}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to