[
https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690935#comment-17690935
]
Ekaterina Dimitrova edited comment on CASSANDRA-18258 at 2/19/23 8:27 PM:
--------------------------------------------------------------------------
{quote}can't go in until CASSANDRA-18255
{quote}
Yes, until then and the drop of JDK8 I guess we should say "Cassandra 5.0
requires Java 8 or Java 11". 17 is still not really supported so I guess we can
skip mentioning it for now? WDYT? Or we can add also "Java 17 experimental" or
so? Open for suggestions.
{quote}nit: regarding target name="_maybe_update_idea_to_java17"
if="java.version.17"
{quote}
That is nothing more than using the same target name but a new one for 17, but
I am open for suggestions.
{quote}why are we encouraging jdk17-only dev?
{quote}
I did not mean to encourage anything. The idea is to create the idea files to
test development with 17. The way we have it also with 11. We need to have it
with the three options so people can easily debug JDK specific issues, no?
I feel it is a matter of wording probably. Again open for suggestions :)
{quote}Patch lgtm otherwise!
{quote}
Thank you for the quick review
was (Author: e.dimitrova):
{quote}can't go in until CASSANDRA-18255
{quote}
Yes, until then and the drop of JDK8 I guess we should say "Cassandra 4.2
requires Java 8 or Java 11". 17 is still not really supported so I guess we can
skip mentioning it for now? WDYT? Or we can add also "Java 17 experimental" or
so? Open for suggestions.
{quote}nit: regarding target name="_maybe_update_idea_to_java17"
if="java.version.17"
{quote}
That is nothing more than using the same target name but a new one for 17, but
I am open for suggestions.
{quote}why are we encouraging jdk17-only dev?
{quote}
I did not mean to encourage anything. The idea is to create the idea files to
test development with 17. The way we have it also with 11. We need to have it
with the three options so people can easily debug JDK specific issues, no?
I feel it is a matter of wording probably. Again open for suggestions :)
{quote}Patch lgtm otherwise!
{quote}
Thank you for the quick review
> Add test conf for JDK17
> -----------------------
>
> Key: CASSANDRA-18258
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18258
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> Post CASSANDRA-18252 and CASSANDRA-18179 we will be able to compile current
> trunk with JDK17 but in order to start Cassandra and test it we will need
> also our conf files updated with some preliminary conf for test purposes.
> This ticket will be used to add those to current trunk
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
