[
https://issues.apache.org/jira/browse/CASSANDRA-18258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691630#comment-17691630
]
Ekaterina Dimitrova edited comment on CASSANDRA-18258 at 2/21/23 2:28 PM:
--------------------------------------------------------------------------
{quote}Good question. This code looks only to flip the language level from one
jdk to the other.
{quote}
No, actually what [~bdeggleston] said:
{quote}That was added because the java 11 needed --add-exports etc, and those
weren't compatible with java 8.
{quote}
And while the --add-exports to compile will be the same for 11 and 17 and
someone could probably argue we can just update the
__maybe_update_idea_to_java11__ to cover 11+17, we also add different jvmargs
in java11-jvmargs and java17-jvmargs. It is similar to us having the separate
jvm11-server.options/jvm17-server.options.
{quote}Agree it would be best if we didn't need separate profile
{quote}
Agreed, we will probably need to have again a community discussion soon after I
commit this ticket In regards to all our JDK internals accesses - Java and
Cassandra future. More to follow.
was (Author: e.dimitrova):
{quote}Good question. This code looks only to flip the language level from one
jdk to the other.
{quote}
No, actually what [~bdeggleston] said:
{quote}That was added because the java 11 needed --add-exports etc, and those
weren't compatible with java 8.
{quote}
And while the --add-exports to compile will be the same for 11 and 17 and
someone could probably argue we can just update the
_{_}maybe_update_idea_to_java11{_} to cover 11+17, we also add different
jvmargs in java11-jvmargs and java17-jvmargs. It is similar to us having the
separate jvm11-server.options/jvm17-server.options.
{quote}Agree it would be best if we didn't need separate profile
{quote}
Agreed, we will probably need to have again a community discussion soon after I
commit this ticket In regards to all our JDK internals accesses - Java and
Cassandra future. More to follow.
> Add test conf for JDK17
> -----------------------
>
> Key: CASSANDRA-18258
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18258
> Project: Cassandra
> Issue Type: Task
> Components: Local/Config
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 4.x
>
>
> Post CASSANDRA-18252 and CASSANDRA-18179 we will be able to compile current
> trunk with JDK17 but in order to start Cassandra and test it we will need
> also our conf files updated with some preliminary conf for test purposes.
> This ticket will be used to add those to current trunk
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
