sarankk commented on PR #31: URL: https://github.com/apache/cassandra-analytics/pull/31#issuecomment-1899368851
As per @yifan-c suggestions, to avoid confusion caused by allowing both `clearSnapshot` option and `snapshotTTL` option, we are going ahead with following setting to determine whether snapshots should be cleared. Introducing a new option `clearSnapshotStrategy`. Possible values it can take are, `clearSnapshotStrategy: onCompletion // Only clear snapshot on the completion of the job. The onCompletion hook is evaluated at the best effort. It is possible the clear snapshot operation is not issued in some circumstances. clearSnapshotStrategy: noOp // Do not clear snapshot at all. clearSnapshotStrategy: onCompletionOrTTL [2d] // Clear the snapshot on completion or after the specified duration (2 days as the default), whichever comes first. Note that there is a risk that the snapshot is deleted before job completion if it takes more than the specified duration. In most cases, the job should complete before the default 2 days clearSnapshotStrategy: TTL [2d] // Only clear snapshot after 2 days clearSnapshot: true === clearSnapshotStrategy: onCompletionOrTTL clearSnapshot: false === clearSnapshotStrategy: noOp` clearSnapshot option will be deprecated. For backward compatibility, we will still understand the option and resolve appropriate `clearSnapshotStrategy` option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
