yifan-c commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462464312
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java:
##########
@@ -138,7 +138,7 @@ private ClearSnapshotStrategy
parseClearSnapshotStrategy(boolean hasDeprecatedOp
boolean
clearSnapshot,
String
clearSnapshotStrategyOption)
{
- if (hasDeprecatedOption)
+ if (hasDeprecatedOption && clearSnapshotStrategyOption == null)
Review Comment:
If the deprecated option is set, the warning should always be logged,
regardless whether the new option is present or not.
```java
if (hasDeprecatedOption)
{
log warning
if (clearSnapshotStrategyOption == null)
{
return the default based on the value
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
