sarankk commented on code in PR #31:
URL:
https://github.com/apache/cassandra-analytics/pull/31#discussion_r1462466619
##########
cassandra-analytics-integration-tests/src/test/java/org/apache/cassandra/analytics/SharedClusterSparkIntegrationTestBase.java:
##########
@@ -84,7 +84,7 @@ protected DataFrameReader bulkReaderDataFrame(QualifiedName
tableName)
// Shutdown hooks are called after the job ends, and in the
case of integration tests
// the sidecar is already shut down before this. Since the
cluster will be torn
// down anyway, the integration job skips clearing snapshots.
- .option("clearSnapshot", "false")
+ .option("clearSnapshotStrategy", "OnCompletion")
Review Comment:
since `onCompletion` behaviour was similar to test setup (clear after test
method completes), kept that. But for consistency, will change it to `noop`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
