olabusayoT commented on code in PR #1427:
URL: https://github.com/apache/daffodil/pull/1427#discussion_r1949677575
##########
daffodil-io/src/main/scala/org/apache/daffodil/io/processors/charset/X_DFDL_MIL_STD.scala:
##########
@@ -126,7 +126,7 @@ object BitsCharset5BitDFI1661DUI001 extends
BitsCharsetNonByteSize {
override lazy val name = "X-DFDL-5-BIT-DFI-1661-DUI-001"
override lazy val bitWidthOfACodeUnit = 5
override lazy val decodeString =
- """\u00A0ABCDEFGHIJKLMNOPQRSTUVWXYZ\uFFFD\uFFFD\uFFFD\uFFFD\uFFFD"""
+ "\u00A0ABCDEFGHIJKLMNOPQRSTUVWXYZ\uFFFD\uFFFD\uFFFD\uFFFD\uFFFD"
Review Comment:
So triple quote now treats unicode chars like literals whereas double quotes
do not iirc. I don't believe it has anything to do with line endings...but the
unciode escapes themselves. IT was suggested by the compiler to used the direct
unicode characters themselves, but I thought that would be difficult to read
and understand compared to using double quotes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]