mbeckerle commented on code in PR #1427: URL: https://github.com/apache/daffodil/pull/1427#discussion_r1951579105
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/infoset/InfosetImpl.scala: ########## @@ -1221,20 +1217,22 @@ final class DIArray( def namedQName = erd.namedQName - protected final var _contents = new ArrayBuffer[DIElement](initialSize) + protected final val _contents = new ArrayBuffer1[DIElement](initialSize) - override def children: LazyList[DINode] = - _contents.view.map(_.asInstanceOf[DINode]).to(LazyList) + override def indexOf(item: DINode): Int = _contents.indexOf(item.asInstanceOf[DIElement]) Review Comment: Thoughts on whether we should do these code improvements or not given that the purpose of this is to change to Scala 2.13 (and eventually 3.0)? Perhaps it is better to change nothing that isn't required by the switch to 2.13, so that the change set is purely about that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
