olabusayoT commented on code in PR #1427:
URL: https://github.com/apache/daffodil/pull/1427#discussion_r1949707448
##########
daffodil-io/src/main/scala/org/apache/daffodil/io/processors/charset/X_DFDL_MIL_STD.scala:
##########
@@ -126,7 +126,7 @@ object BitsCharset5BitDFI1661DUI001 extends
BitsCharsetNonByteSize {
override lazy val name = "X-DFDL-5-BIT-DFI-1661-DUI-001"
override lazy val bitWidthOfACodeUnit = 5
override lazy val decodeString =
- """\u00A0ABCDEFGHIJKLMNOPQRSTUVWXYZ\uFFFD\uFFFD\uFFFD\uFFFD\uFFFD"""
+ "\u00A0ABCDEFGHIJKLMNOPQRSTUVWXYZ\uFFFD\uFFFD\uFFFD\uFFFD\uFFFD"
Review Comment:
Hmm that's correct, but what's the advantage of triple quotes with unicode
escape vs double quotes with unicode escapes other than multiline strings
(which we didn't use in our code)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
