olabusayoT commented on code in PR #1427: URL: https://github.com/apache/daffodil/pull/1427#discussion_r1951617251
########## daffodil-runtime1/src/main/scala/org/apache/daffodil/runtime1/infoset/InfosetImpl.scala: ########## @@ -1221,20 +1217,22 @@ final class DIArray( def namedQName = erd.namedQName - protected final var _contents = new ArrayBuffer[DIElement](initialSize) + protected final val _contents = new ArrayBuffer1[DIElement](initialSize) - override def children: LazyList[DINode] = - _contents.view.map(_.asInstanceOf[DINode]).to(LazyList) + override def indexOf(item: DINode): Int = _contents.indexOf(item.asInstanceOf[DIElement]) Review Comment: > Perhaps it is better to change nothing that isn't required by the switch to 2.13 Just a note that the above changes were done because of issues with doing a non-copying ArrayBuffer.toIndexedSeq, so it was a small refactor required for switching to 2.13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
