yiguolei commented on code in PR #60587:
URL: https://github.com/apache/doris/pull/60587#discussion_r2844338364
##########
be/src/olap/rowset/segment_v2/zone_map_index.cpp:
##########
@@ -44,22 +48,43 @@ struct uint24_t;
namespace segment_v2 {
template <PrimitiveType Type>
-TypedZoneMapIndexWriter<Type>::TypedZoneMapIndexWriter(Field* field) :
_field(field) {
- _page_zone_map.min_value = _field->allocate_zone_map_value(_arena);
- _page_zone_map.max_value = _field->allocate_zone_map_value(_arena);
+TypedZoneMapIndexWriter<Type>::TypedZoneMapIndexWriter(vectorized::DataTypePtr&&
data_type)
+ : _data_type(std::move(data_type)) {
+ _page_zone_map.min_value = doris::vectorized::Field(Type);
+ _page_zone_map.max_value = doris::vectorized::Field(Type);
+ _segment_zone_map.min_value = doris::vectorized::Field(Type);
+ _segment_zone_map.max_value = doris::vectorized::Field(Type);
_reset_zone_map(&_page_zone_map);
- _segment_zone_map.min_value = _field->allocate_zone_map_value(_arena);
- _segment_zone_map.max_value = _field->allocate_zone_map_value(_arena);
_reset_zone_map(&_segment_zone_map);
}
+template <PrimitiveType Type>
+void TypedZoneMapIndexWriter<Type>::_direct_copy_may_cut(
Review Comment:
add detailed comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
