yiguolei commented on code in PR #60587:
URL: https://github.com/apache/doris/pull/60587#discussion_r2844639424
##########
be/src/olap/rowset/segment_v2/zone_map_index.cpp:
##########
@@ -80,31 +105,83 @@ void TypedZoneMapIndexWriter<Type>::add_values(const void*
values, size_t count)
}
}
}
- if (min < unaligned_load<ValType>(_page_zone_map.min_value)) {
- _field->type_info()->direct_copy_may_cut(_page_zone_map.min_value,
- reinterpret_cast<const
void*>(&min));
+ if (!_page_zone_map.is_min_max_set() || min <
_page_zone_map.min_value.get<Type>()) {
Review Comment:
is_min_max_set 这个好像 等价于
！_page_zone_map.has_not_null，我们可以吧_page_zone_map.has_not_null = true 放到末尾
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
