yiguolei commented on code in PR #60587:
URL: https://github.com/apache/doris/pull/60587#discussion_r2844651437
##########
be/src/olap/rowset/segment_v2/column_reader.cpp:
##########
@@ -499,9 +499,13 @@ Status ColumnReader::prune_predicates_by_zone_map(
return Status::OK();
}
-Status ColumnReader::_parse_zone_map(const ZoneMapPB& zone_map, ZoneMapInfo&
zone_map_info) const {
+Status ColumnReader::_parse_zone_map(const ZoneMapPB& zone_map, ZoneMap&
zone_map_info) const {
zone_map_info.has_null = zone_map.has_null();
- zone_map_info.is_all_null = !zone_map.has_not_null();
+ zone_map_info.has_not_null = zone_map.has_not_null();
+ zone_map_info.pass_all = zone_map.pass_all();
+ zone_map_info.has_negative_inf = zone_map.has_negative_inf();
+ zone_map_info.has_positive_inf = zone_map.has_positive_inf();
+ zone_map_info.has_nan = zone_map.has_nan();
// min value and max value are valid if has_not_null is true
if (zone_map.has_not_null()) {
Review Comment:
这个逻辑可能不对。 如果add values 的时候，前10个都add 成功了，那么has not null == true；但是后来又pass all
= true，此时pb 的min和max 是 空，不一定能parse
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
