yiguolei commented on code in PR #60587:
URL: https://github.com/apache/doris/pull/60587#discussion_r2844626372
##########
be/src/olap/field.h:
##########
@@ -414,31 +312,10 @@ class StringField : public Field {
return local;
}
- char* allocate_value(vectorized::Arena& arena) const override {
- return Field::allocate_string_value(arena);
- }
-
- char* allocate_zone_map_value(vectorized::Arena& arena) const override {
- char* type_value = arena.alloc(sizeof(Slice));
- auto slice = reinterpret_cast<Slice*>(type_value);
- slice->size = MAX_ZONE_MAP_INDEX_SIZE;
- slice->data = arena.alloc(slice->size);
- return type_value;
- }
void set_to_max(char* ch) const override {
auto slice = reinterpret_cast<Slice*>(ch);
memset(slice->data, 0xFF, slice->size);
}
- // only varchar/string filed need modify zone map index when zone map
max_value
- // index longer than `MAX_ZONE_MAP_INDEX_SIZE`. so here we add one
- // for the last byte
- // In UTF8 encoding, here do not appear 0xff in last byte
- void modify_zone_map_index(char* src) const override {
- auto slice = reinterpret_cast<Slice*>(src);
- if (slice->size == MAX_ZONE_MAP_INDEX_SIZE) {
- slice->mutable_data()[slice->size - 1] += 1;
- }
- }
void set_to_zone_map_max(char* ch) const override {
Review Comment:
set_to_zone_map_max 这个方法还有用吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
