yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3287100595
##########
be/src/storage/segment/vertical_segment_writer.cpp:
##########
@@ -1214,7 +1218,7 @@ std::string VerticalSegmentWriter::_full_encode_keys(
}
encoded_keys.push_back(KEY_NORMAL_MARKER);
DCHECK(key_coders[cid] != nullptr);
- key_coders[cid]->full_encode_ascending(field, &encoded_keys);
+ key_coders[cid]->full_encode_ascending(field, &encoded_keys,
key_index_sizes[cid]);
Review Comment:
这种API 不要这么继续改下去了，一般是把返回值放在最后，咱们不要每次加参数都往后一直堆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
