yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3287187535
##########
be/src/storage/segment/segment_writer.cpp:
##########
@@ -833,13 +834,15 @@ std::string SegmentWriter::_full_encode_keys(
assert(_key_index_size.size() == _num_sort_key_columns);
assert(key_columns.size() == _num_sort_key_columns &&
_key_coders.size() == _num_sort_key_columns);
- return _full_encode_keys(_key_coders, key_columns, pos, null_first);
+ return _full_encode_keys(_key_coders, _key_index_size, key_columns, pos,
null_first);
}
std::string SegmentWriter::_full_encode_keys(
const std::vector<const KeyCoder*>& key_coders,
+ const std::vector<uint16_t>& key_index_sizes,
Review Comment:
为什么要多这个参数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
