yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3287159272
##########
be/src/storage/segment/column_reader.cpp:
##########
@@ -2436,7 +2436,10 @@ Status FileColumnIterator::_read_dict_data() {
RETURN_IF_ERROR(_reader->read_page(_opts,
_reader->get_dict_page_pointer(), &_dict_page_handle,
&dict_data, &dict_footer,
_compress_codec, true));
const EncodingInfo* encoding_info;
- RETURN_IF_ERROR(EncodingInfo::get(FieldType::OLAP_FIELD_TYPE_VARCHAR,
+ // The dict pool stores strings of the outer column's type. Using the
+ // outer type (CHAR vs VARCHAR/STRING) lets the EncodingInfo pick a
+ // CHAR-strip pre-decoder so the cached dict page is already unpadded.
+ RETURN_IF_ERROR(EncodingInfo::get(_reader->get_meta_type(),
Review Comment:
这里难道之前，我们都传递varchar，底层不感知具体的类型？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
