yiguolei commented on code in PR #63291:
URL: https://github.com/apache/doris/pull/63291#discussion_r3287113884
##########
be/src/storage/segment/binary_dict_page_pre_decoder.h:
##########
@@ -102,9 +111,21 @@ struct BinaryDictPagePreDecoder : public
DataPagePreDecoder {
break;
}
case PLAIN_ENCODING_V2: {
- // Use BinaryPlainPageV2PreDecoder with total_prefix to reserve
space
- BinaryPlainPageV2PreDecoder v2_decoder;
- status = v2_decoder.decode(&decoded_page, &data_without_header,
size_of_tail,
+ if constexpr (IS_CHAR) {
+ BinaryPlainPageV2CharStripPreDecoder v2_decoder;
+ status = v2_decoder.decode(&decoded_page,
&data_without_header, size_of_tail,
+ _use_cache, page_type, file_path,
total_prefix);
+ } else {
+ BinaryPlainPageV2PreDecoder v2_decoder;
+ status = v2_decoder.decode(&decoded_page,
&data_without_header, size_of_tail,
+ _use_cache, page_type, file_path,
total_prefix);
+ }
+ break;
+ }
+ case PLAIN_ENCODING: {
+ // Only reachable when IS_CHAR (non-CHAR returned earlier).
Review Comment:
如果有这种假设，应该加一个check，如果不是is char 就应该挂掉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
