clintropolis commented on code in PR #18307:
URL: https://github.com/apache/druid/pull/18307#discussion_r2223851969
##########
processing/src/main/java/org/apache/druid/query/aggregation/NullableNumericAggregatorFactory.java:
##########
@@ -48,31 +50,44 @@
public abstract class NullableNumericAggregatorFactory<T extends
BaseNullableColumnValueSelector>
extends AggregatorFactory
{
+ /**
+ * If this aggregator does not aggregate any values, it will return this
value.
+ */
+ @Nullable
+ public Number getDefaultValue()
+ {
+ return null;
+ }
Review Comment:
thinking more about this, i guess `isNullable` isn't really the best name,
this aggregator factory is for null handling, rather its like some check for if
the input is nullable or not and so whether or not to use the `NullableNumeric`
wrappers...
maybe `isForceNotNullable()` or something better captures the spirit of this
flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
