cecemei commented on code in PR #18307:
URL: https://github.com/apache/druid/pull/18307#discussion_r2224207411
##########
processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerTest.java:
##########
@@ -3399,26 +3399,70 @@ public void
testGroupByWithUniquesAndPostAggWithSameName()
@Test
public void testGroupByWithCardinality()
{
- GroupByQuery query = makeQueryBuilder()
+ // arrange
Review Comment:
i feel it's more clear if we separate out the arrange act assert part a bit
more, and it really helped for long test functions, maybe less as in shorter
ones. calling it out specifically so bringing more awareness to this pattern
when writing unit tests, sometimes it's not followed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
