cecemei commented on code in PR #18307:
URL: https://github.com/apache/druid/pull/18307#discussion_r2224205765
##########
processing/src/main/java/org/apache/druid/query/timeseries/TimeseriesQueryEngine.java:
##########
@@ -181,7 +181,8 @@ private Sequence<Result<TimeseriesResultValue>>
processVectorized(
.simple(granularizer.getBucketIterable())
.map(
bucketInterval -> {
- // Whether or not the current bucket is empty
+ // If current bucket is empty and skipEmptyBuckets is
true, return null.
+ // Otherwise, always call aggregators.init, then
aggregators.aggregateVector if there's any data.
Review Comment:
i'd think this is more like describing what the entire function does,
considering that:
- the `init` is being called in two places, so just want to call out early
here
- when non-vector, there's no such thing, so thought it might be nice to
call out early
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
