kfaraz commented on code in PR #18307:
URL: https://github.com/apache/druid/pull/18307#discussion_r2224322582
##########
processing/src/test/java/org/apache/druid/query/groupby/GroupByQueryRunnerTest.java:
##########
@@ -3399,26 +3399,70 @@ public void
testGroupByWithUniquesAndPostAggWithSameName()
@Test
public void testGroupByWithCardinality()
{
- GroupByQuery query = makeQueryBuilder()
+ // arrange
Review Comment:
My 2 cents: we can either skip the comment altogether as suggested by
@clintropolis.
The arrange-act-assert is more preferably captured in the test name itself.
However, for long methods, if we choose to add comments, they should be a
little more informative.
Otherwise, they do not add any value and we do just ignore them while
reading.
e.g. instead of "assert", it could be something like "Verify that ...
whatever you are verifying"
but only something which might not be readily apparent when looking at the
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
