samarthjain commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r277422743
########## File path: server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java ########## @@ -183,28 +172,17 @@ public void dropSegment( final LoadPeonCallback callback Review comment: The old code was synchronizing on ```currentlyProcessing``` since it was concurrently accessed by multiple threads. Of special interest were these two places - https://github.com/apache/incubator-druid/blob/master/server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java#L318 and https://github.com/apache/incubator-druid/blob/master/server/src/main/java/org/apache/druid/server/coordinator/CuratorLoadQueuePeon.java#L224 This was the key reason behind the peon assigning segments serially. It would wait for the previous load/drop request to complete before starting a new one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org For additional commands, e-mail: commits-h...@druid.apache.org